🔧 MAINTAIN: Fix tests if Token.attrs is of type List[tuple]] #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
hukkin changed the title Token.attrs is of type List[tuple]]Token.attrs is of type List[tuple]] 
| superseded by #13 |
| @chrisjsewell I believe we still need the test assertion fixes in this PR, in case executablebooks/markdown-it-py#102 is merged. |
| Bet we don't 😉 |
| Haha, lets see I'm not 100% sure either. But surely that makes the upstream |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR will fix tests if executablebooks/markdown-it-py#102 is merged to
markdown-it-py.mdit-py-pluginsdoes not mutateToken.attrsitems though so even though test assertions break, no functional code should break if executablebooks/markdown-it-py#102 is merged