🐛 FIX: cli.parse: return 0 for non-error #53 #55
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
westurner force-pushed the BUG_fix_cli_returncode branch from 2578c9c to 386be1c Compare 
Codecov Report
@@ Coverage Diff @@ ## master #55 +/- ## ========================================== + Coverage 95.40% 95.43% +0.02% ========================================== Files 75 73 -2 Lines 3745 3567 -178 ========================================== - Hits 3573 3404 -169 + Misses 172 163 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
westurner force-pushed the BUG_fix_cli_returncode branch from 386be1c to 1a27821 Compare westurner changed the title 
chrisjsewell reviewed Oct 1, 2020
westurner force-pushed the BUG_fix_cli_returncode branch from 1a27821 to 1d71c4c Compare 
hukkin reviewed Oct 23, 2020
Co-authored-by: Taneli Hukkinen <hukkinj1@users.noreply.github.com>
hukkin reviewed Oct 31, 2020
| def test_parse_fail(): | ||
| with pytest.raises(SystemExit) as exc_info: | ||
| parse.main(["/tmp/nonexistant_path/for_cli_test.md"]) | ||
| assert exc_info.value.code == 1 |
There was a problem hiding this comment.
One way to fix the test failure is:
Suggested change
| assert exc_info.value.code == 1 | |
| assert isinstance(exc_info.value.code, str) |
Another way, that I personally would prefer but don't know if @chrisjsewell would, is go to markdown_it.cli.parse.convert_file and replace
sys.exit('Cannot open file "{}".'.format(filename))with
sys.stderr.write('Cannot open file "{}".\n'.format(filename)) sys.exit(1)
| Superseded by #124 |
| Thanks |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is necessary so that make doesn't fail to execute this task due to
markdown-itreturning True (1) instead of zero (0) for success: