⬆️ Comply with Commonmark 0.31.2 #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This PR ports markdown-it/markdown-it@cd24778, which in turn complies with https://spec.commonmark.org/0.31.2/changes.html: - Unicode: ```diff A [Unicode punctuation character](@) is - an [ASCII punctuation character] or anything in - he general Unicode categories `Pc`, `Pd`, `Pe`, `Pf`, `Pi`, `Po`, or `Ps`. + a character in the Unicode `P` (puncuation) or `S` (symbol) general categories. ``` - HTML comments: ```diff - An HTML comment consists of `<!--` + *text* + `-->`, - where *text* does not start with `>` or `->`, does not end with `-`, and does not contain `--`. - (See the [HTML5 spec](http://www.w3.org/TR/html5/syntax.html#comments).) + An [HTML comment](@) consists of `<!-->`, `<!--->`, or `<!--`, a string of characters not including the string `-->`, and `-->` + (see the [HTML spec](https://html.spec.whatwg.org/multipage/parsing.html#markup-declaration-open-state)). ``` - HTML blocks: ```diff Start condition: line begins the string < or </ followed by one of the strings (case-insensitive) - `section`, `source`, `summary`, `table`, `tbody`, `td`, + `search`, `section`, `summary`, `table`, `tbody`, `td`, ``` - Setext header: ```diff - If a line containing a single `-` can be interpreted as an - empty [list items], it should be interpreted this way - and not as a [setext heading underline]. ```
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #362 +/- ## ======================================= Coverage 95.77% 95.77% ======================================= Files 64 64 Lines 3429 3429 ======================================= Hits 3284 3284 Misses 145 145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR ports markdown-it/markdown-it@cd24778, which in turn complies with https://spec.commonmark.org/0.31.2/changes.html:
Unicode:
HTML comments:
HTML blocks:
Another notable change in the diff was Setext headers, although there appears to be no change to the port of tests in this respect: