Skip to content

Conversation

hukkin
Copy link
Contributor

@hukkin hukkin commented Jul 12, 2021

I'll propose this change upstream and add a link here soon. Probably don't want to merge before accepted upstream.

EDIT: Here's the upstream PR markdown-it/markdown-it#799

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #169 (76240fe) into master (0195be3) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 76240fe differs from pull request most recent head 2870234. Consider uploading reports for the commit 2870234 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@ ## master #169 +/- ## ======================================= Coverage 96.08% 96.08% ======================================= Files 60 60 Lines 3242 3242 ======================================= Hits 3115 3115 Misses 127 127 
Flag Coverage Δ
pytests 96.08% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
markdown_it/rules_block/code.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0195be3...2870234. Read the comment docs.

@hukkin hukkin marked this pull request as ready for review July 15, 2021 20:14
@hukkin
Copy link
Contributor Author

hukkin commented Jul 15, 2021

Upstream PR is merged so this should be good to go. Would probably be good to do #168 first though, and then rebase this on master and update port.yaml.

@chrisjsewell
Copy link
Member

cheers, will try to have a look in the not too distant future

@chrisjsewell
Copy link
Member

I guess this can now be incorporated into a markdown-it/markdown-it@12.1.0...12.2.0 sync

@hukkin hukkin force-pushed the fix-code-block-no-newline branch from 0030ef7 to 76240fe Compare August 17, 2021 17:43
@hukkin
Copy link
Contributor Author

hukkin commented Aug 17, 2021

I guess this can now be incorporated into a markdown-it/markdown-it@12.1.0...12.2.0 sync

Yeah. I don't have the time to do that right now, but did rebase and update port.yaml. So this should also be mergeable as is.

@chrisjsewell
Copy link
Member

I don't have the time to do that right now

tssk, so lazy 😜 yeh no worries, there is nothing in there that is a big priority and plenty busy myself

@chrisjsewell chrisjsewell changed the title FIX: Always suffix indented code block with newline 🐛 FIX: Always suffix indented code block with newline Dec 1, 2021
@chrisjsewell chrisjsewell merged commit 22a65b3 into executablebooks:master Dec 1, 2021
@hukkin hukkin deleted the fix-code-block-no-newline branch December 1, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants