📚 DOCS: Fix deprecated import #150
Conversation
Hello, I was playing with this package and noticed that there are a couple of warning messages with the current important commands. Also one other suggestion is to add some code for people to export the html to a file if they happen to not be working in an interactive python session. Happy to remove this if it doesn't make sense for others.
| Thanks for submitting your first pull request! You are awesome! 🤗 |
Codecov Report
@@ Coverage Diff @@ ## master #150 +/- ## ======================================= Coverage 96.32% 96.32% ======================================= Files 72 72 Lines 3266 3266 ======================================= Hits 3146 3146 Misses 120 120
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
thanks @firasm, can you change the file writing code though
README.md Outdated
| #text_file = open("output.html", "w") | ||
| #text_file.write(html_text) | ||
| #text_file.close() |
There was a problem hiding this comment.
This should either use:
with open("output.html", "w") as handle: handle.write(html_text)or probably better these days
from pathlib import Path Path("output.html").write_text(html_text)There was a problem hiding this comment.
actually I'll just change it
chrisjsewell changed the title | Congrats on your first merged pull request in this project! 🎉 |
| Thanks! By the time I woke up today your suggested change was already done :-) Hard to unlearn how to write to files! |
| Yeh I was too impatient lol |
2 participants
Hello,
I was playing with this package and noticed that there are a couple of warning messages with the current important commands.
Also one other suggestion is to add some code for people to export the html to a file if they happen to not be working in an interactive python session. Happy to remove this if it doesn't make sense for others.