Skip to content

Conversation

@hukkin
Copy link
Contributor

@hukkin hukkin commented Dec 27, 2020

A continuation on #109 (based on the branch there). Adds the changes in markdown-it/markdown-it@11.0.1...12.0.4 on top

#109 can be merged first and then this one (to make review easier), or this can be merged directly.

@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #110 (55bc081) into master (29a8d5e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #110 +/- ## ========================================== - Coverage 96.51% 96.51% -0.01%  ========================================== Files 72 72 Lines 3185 3183 -2 ========================================== - Hits 3074 3072 -2  Misses 111 111 
Flag Coverage Δ
pytests 96.51% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
markdown_it/renderer.py 98.19% <ø> (-0.02%) ⬇️
markdown_it/rules_inline/strikethrough.py 97.40% <ø> (ø)
markdown_it/rules_inline/autolink.py 96.22% <100.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a06bfc...d15063e. Read the comment docs.

@hukkin hukkin changed the title Catch up with markdown-it v12.0.0 Catch up with markdown-it v12.0.2 Dec 27, 2020
@hukkin hukkin changed the title Catch up with markdown-it v12.0.2 Catch up with markdown-it v12.0.4 Dec 27, 2020
@hukkin
Copy link
Contributor Author

hukkin commented Jan 1, 2021

[12.0.4] - 2020-12-20

Fixed

  • Fix crash introduced in 12.0.3 when processing strikethrough (~~) and similar plugins, #742.
  • Avoid fenced token mutation, #745.

[12.0.3] - 2020-12-07

Fixed

  • [](<foo<bar>) is no longer a valid link.
  • [](url (xxx()) is no longer a valid link.
  • [](url\ xxx) is no longer a valid link.
  • Fix performance issues when parsing links (#732, #734), backticks, (#733, #736),
    emphases (#735), and autolinks (#737).
  • Allow newline in <? ... ?> in an inline context.
  • Allow <meta> html tag to appear in an inline context.

[12.0.2] - 2020-10-23

Fixed

  • Three pipes (|\n|\n|) are no longer rendered as a table with no columns, #724.

[12.0.1] - 2020-10-19

Fixed

  • Fix tables inside lists indented with tabs, #721.

[12.0.0] - 2020-10-14

Changed

  • Added 3rd argument to highlight(code, lang, attrs), #626.
  • Rewrite tables according to latest GFM spec, #697.

Fixed

  • Fix mappings for table rows (amended fix made in 11.0.1), #705.
  • %25 is no longer decoded in beautified urls, #720.
@chrisjsewell
Copy link
Member

I think maybe split this up into a few defined commits, e.g. one for links, one for the table etc?

For tables what is the actual difference? are there table syntaxes that were not allowed before or are allowed now? Is there any tests we can add to highlight the difference?

@chrisjsewell
Copy link
Member

is there any tests we can add to highlight the difference?

ah oops, I missed the changes to tables.md (because the diff was collapsed)

@hukkin
Copy link
Contributor Author

hukkin commented Jan 15, 2021

I think maybe split this up into a few defined commits, e.g. one for links, one for the table etc?

This might be nice to have, but at least I find it hard to motivate myself to do this 😄 I don't mind at all if you take the changes and redo the commit history.

For tables what is the actual difference? are there table syntaxes that were not allowed before or are allowed now? Is there any tests we can add to highlight the difference?

The test cases I re-added show some changes. I think it's a bit hard to argue more about the changes, since previously there was no formal spec that was followed.

@chrisjsewell
Copy link
Member

I don't mind at all if you take the changes and redo the commit history.

@hukkinj1 with any luck this should have now been fully covered by #140
If you want to check and close this

@hukkin
Copy link
Contributor Author

hukkin commented Mar 10, 2021

Nice, I merged master to this and as a result there's still a few changes left here that seem like they belong in master.

@chrisjsewell
Copy link
Member

From the merge conflicts I noticed a few minor errors that I'm just about to commit

chrisjsewell added a commit that referenced this pull request Mar 10, 2021
Comparing to #110 I noticed a few mistaken regressions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants