Add support for ShowReturnValue Debugger setting (microsoft#2852)

* Add showReturnValue debugger setting * Update tests to support showReturnValue setting * Address comments

Author: karthiknadig

.gitignore

@@ -22,3 +22,4 @@ obj/**
 .pytest_cache
 tmp/**
 .python-version
+.vs/

news/1 Enhancements/2463.md

@@ -0,0 +1 @@
+Added a debugger setting to show return values of functions while stepping.

package.json

@@ -490,6 +490,11 @@
  "description": "Automatically stop after launch.",
  "default": false
  },
+ "showReturnValue": {
+ "type": "boolean",
+ "description": "Show return value of functions when stepping.",
+ "default": false
+ },
  "console": {
  "enum": [
  "none",

src/client/debugger/debugAdapter/DebugClients/LocalDebugClient.ts

@@ -20,7 +20,8 @@ import { DebugClientHelper } from './helper';
 const VALID_DEBUG_OPTIONS = [
  'RedirectOutput',
  'DebugStdLib',
- 'stopOnEntry',
+ 'StopOnEntry',
+ 'ShowReturnValue',
  'BreakOnSystemExitZero',
  'DjangoDebugging',
  'Django'];

src/client/debugger/extension/configProviders/baseProvider.ts

@@ -72,6 +72,9 @@ export abstract class BaseConfigurationProvider implements DebugConfigurationPro
  if (typeof debugConfiguration.stopOnEntry !== 'boolean') {
  debugConfiguration.stopOnEntry = false;
  }
+ if (typeof debugConfiguration.showReturnValue !== 'boolean') {
+ debugConfiguration.showReturnValue = false;
+ }
  if (!debugConfiguration.console) {
  debugConfiguration.console = 'integratedTerminal';
  }

src/client/debugger/extension/configProviders/pythonV2Provider.ts

@@ -28,6 +28,9 @@ export class PythonV2DebugConfigurationProvider extends BaseConfigurationProvide
  if (debugConfiguration.stopOnEntry) {
  this.debugOption(debugOptions, DebugOptions.StopOnEntry);
  }
+ if (debugConfiguration.showReturnValue) {
+ this.debugOption(debugOptions, DebugOptions.ShowReturnValue);
+ }
  if (debugConfiguration.django) {
  this.debugOption(debugOptions, DebugOptions.Django);
  }
@@ -136,7 +139,8 @@ export class PythonV2DebugConfigurationProvider extends BaseConfigurationProvide
  isSudo: !!debugConfiguration.sudo,
  jinja: !!debugConfiguration.jinja,
  pyramid: !!debugConfiguration.pyramid,
- stopOnEntry: !!debugConfiguration.stopOnEntry
+ stopOnEntry: !!debugConfiguration.stopOnEntry,
+ showReturnValue: !!debugConfiguration.showReturnValue
  };
  sendTelemetryEvent(DEBUGGER, undefined, telemetryProps);
  }

src/client/debugger/types.ts

@@ -17,7 +17,8 @@ export enum DebugOptions {
  FixFilePathCase = 'FixFilePathCase',
  WindowsClient = 'WindowsClient',
  UnixClient = 'UnixClient',
- StopOnEntry = 'StopOnEntry'
+ StopOnEntry = 'StopOnEntry',
+ ShowReturnValue = 'ShowReturnValue'
 }
 
 // tslint:disable-next-line:interface-name
@@ -30,6 +31,7 @@ interface AdditionalLaunchDebugOptions {
  sudo?: boolean;
  pyramid?: boolean;
  stopOnEntry?: boolean;
+ showReturnValue?: boolean;
 }
 
 // tslint:disable-next-line:interface-name
@@ -50,6 +52,8 @@ export interface LaunchRequestArguments extends DebugProtocol.LaunchRequestArgum
  pythonPath: string;
  // Automatically stop target after launch. If not specified, target does not stop.
  stopOnEntry?: boolean;
+ /** Show return values of functions while stepping. */
+ showReturnValue?: boolean;
  args: string[];
  cwd?: string;
  debugOptions?: DebugOptions[];

src/client/telemetry/types.ts

@@ -55,6 +55,7 @@ export type DebuggerTelemetryV2 = {
  isModule: boolean;
  isSudo: boolean;
  stopOnEntry: boolean;
+ showReturnValue: boolean;
  pyramid: boolean;
 };
 export type DebuggerPerformanceTelemetry = {

src/test/debugger/configProvider/provider.unit.test.ts

@@ -270,8 +270,9 @@ suite('Debugging - Config Provider', () => {
 
  expect(debugConfig).to.have.property('console', 'integratedTerminal');
  expect(debugConfig).to.have.property('stopOnEntry', false);
+ expect(debugConfig).to.have.property('showReturnValue', false);
  expect(debugConfig).to.have.property('debugOptions');
- expect((debugConfig as any).debugOptions).to.be.deep.equal(['RedirectOutput']);
+ expect((debugConfig as any).debugOptions).to.be.deep.equal([DebugOptions.RedirectOutput]);
  });
  test('Test defaults of python debugger', async () => {
  if ('python' === DebuggerTypeName) {
@@ -286,6 +287,7 @@ suite('Debugging - Config Provider', () => {
  const debugConfig = await debugProvider.resolveDebugConfiguration!(workspaceFolder, {} as DebugConfiguration);
 
  expect(debugConfig).to.have.property('stopOnEntry', false);
+ expect(debugConfig).to.have.property('showReturnValue', false);
  expect(debugConfig).to.have.property('debugOptions');
  expect((debugConfig as any).debugOptions).to.be.deep.equal([DebugOptions.RedirectOutput]);
  });
@@ -300,6 +302,7 @@ suite('Debugging - Config Provider', () => {
 
  expect(debugConfig).to.have.property('console', 'integratedTerminal');
  expect(debugConfig).to.have.property('stopOnEntry', false);
+ expect(debugConfig).to.have.property('showReturnValue', false);
  expect(debugConfig).to.have.property('debugOptions');
  expect((debugConfig as any).debugOptions).to.be.deep.equal([]);
  });

src/test/debugger/misc.test.ts

@@ -56,13 +56,14 @@ suite(`Standard Debugging - Misc tests: ${debuggerType}`, () => {
  return new DebugClientEx(testAdapterFilePath, debuggerType, coverageDirectory, { cwd: EXTENSION_ROOT_DIR });
  }
  }
- function buildLaunchArgs(pythonFile: string, stopOnEntry: boolean = false): LaunchRequestArguments {
+ function buildLaunchArgs(pythonFile: string, stopOnEntry: boolean = false, showReturnValue: boolean = false): LaunchRequestArguments {
  const env = { PYTHONPATH: PTVSD_PATH };
  // tslint:disable-next-line:no-unnecessary-local-variable
  const options = {
  program: path.join(debugFilesPath, pythonFile),
  cwd: debugFilesPath,
  stopOnEntry,
+ showReturnValue,
  debugOptions: [DebugOptions.RedirectOutput],
  pythonPath: PYTHON_PATH,
  args: [],