Fix a crash when the segment does not point to a source file #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
With the following example: ```js var foo = function () { return 4; }; //# sourceMappingURL=data:application/json;charset=utf-8;base64,ewogICJtYXBwaW5ncyI6ICJBQUFBLElBQUEsR0FBQSxHQUFVLFk7U0FBTSxDO0FBQUMsQ0FBakIiLAogICJuYW1lcyI6IFtdLAogICJzb3VyY2VzIjogWyJvcmlnaW5hbC5qcyJdLAogICJzb3VyY2VzQ29udGVudCI6IFsidmFyIGZvbyA9ICgpID0+IDQ7Il0sCiAgInZlcnNpb24iOiAzCn0K ``` Hovering over the `{` or `;` (on line 2) causes a crash. The actually mappings looks like: ``` AAAA,IAAA,GAAA,GAAU,Y;SAAM,C;AAAC,CAAjB ``` Where the `Y` and `C` segments do not have a `sourcesIndex`/`sourceLine`/`sourceColumn` VLQ. This defaults the source `index` variable here to `-1`, which causes the crash. 
Contributor Author
Owner
| Sure thing. Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
With the following example:
Hovering over the
{or;(on line 2) in the Generated Code section causes a crash. The actual mappings looks like:Where the
YandCsegments do not have asourcesIndex/sourceLine/sourceColumnVLQ. This defaults the sourceindexvariable here to-1, which causes the crash.