Skip to content

Make Configuration.from_ methods accept Path #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2020
Merged

Make Configuration.from_ methods accept Path #300

merged 1 commit into from
Oct 16, 2020

Conversation

JarnoRFB
Copy link
Contributor

@JarnoRFB JarnoRFB commented Oct 16, 2020 •
edited
Loading

The methods were already compatible with pathlib.Path and just did not accept it in their signatures.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.799% when pulling 8a23c1f on JarnoRFB:feature/configure-with-path into 39f3f3a on ets-labs:master.
@rmk135 rmk135 self-requested a review October 16, 2020 13:53
@rmk135
Copy link
Member

rmk135 commented Oct 16, 2020

Hey @JarnoRFB ,

That looks good, thanks.

Can you, please, re-target the source branch to "develop"?
@rmk135 rmk135 changed the base branch from master to develop October 16, 2020 17:56
@rmk135
Copy link
Member

rmk135 commented Oct 16, 2020

Never mind, I have realized I can do it myself.
@rmk135 rmk135 merged commit 819023e into ets-labs:develop Oct 16, 2020
@rmk135
Copy link
Member

rmk135 commented Oct 16, 2020

Change is released as 4.0.1 http://python-dependency-injector.ets-labs.org/main/changelog.html#id1

Thanks for the contribution @JarnoRFB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@JarnoRFB @coveralls @rmk135