- Notifications
You must be signed in to change notification settings - Fork 21.4k
crypto/bn256: default to gnark #32024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+4 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Benchmarks of this PR on M2 MBP (arm):
Benchmarks on master:
|
this was merged in #32026 |
@jwasinger I only merged it into the performance branch, we should keep this PR to merge it into master |
MariusVanDerWijden approved these changes Jun 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
howjmay pushed a commit to iotaledger/go-ethereum that referenced this pull request Aug 27, 2025
howjmay pushed a commit to iotaledger/go-ethereum that referenced this pull request Aug 27, 2025
This reverts commit e0cf89e.
gballet pushed a commit to gballet/go-ethereum that referenced this pull request Sep 11, 2025
gballet pushed a commit to gballet/go-ethereum that referenced this pull request Sep 11, 2025
This reverts commit e0cf89e.
fjl pushed a commit that referenced this pull request Sep 19, 2025
We recently update our default implementation to gnark in #32024 Then we found a consensus issue and reverted it in 65d77c5 We fixed the consensus issue and have been fuzzing it more since then in https://github.com/ethereum/go-ethereum/pull/32055/files #32065 https://github.com/ethereum/go-ethereum/pull/32055/files So I think now is the time to update it back to gnark
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2025
We recently update our default implementation to gnark in ethereum#32024 Then we found a consensus issue and reverted it in ethereum@65d77c5 We fixed the consensus issue and have been fuzzing it more since then in https://github.com/ethereum/go-ethereum/pull/32055/files ethereum#32065 https://github.com/ethereum/go-ethereum/pull/32055/files So I think now is the time to update it back to gnark
gzliudan added a commit to XinFinOrg/XDPoSChain that referenced this pull request Sep 23, 2025
We recently update our default implementation to gnark in ethereum#32024 Then we found a consensus issue and reverted it in ethereum@65d77c5 We fixed the consensus issue and have been fuzzing it more since then in https://github.com/ethereum/go-ethereum/pull/32055/files ethereum#32065 https://github.com/ethereum/go-ethereum/pull/32055/files So I think now is the time to update it back to gnark Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>
Sahil-4555 pushed a commit to Sahil-4555/go-ethereum that referenced this pull request Oct 12, 2025
We recently update our default implementation to gnark in ethereum#32024 Then we found a consensus issue and reverted it in ethereum@65d77c5 We fixed the consensus issue and have been fuzzing it more since then in https://github.com/ethereum/go-ethereum/pull/32055/files ethereum#32065 https://github.com/ethereum/go-ethereum/pull/32055/files So I think now is the time to update it back to gnark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.