Skip to content

feat(fw,tests): change EOF to stack_height_increase #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chfast merged 1 commit into from
Apr 14, 2025
Merged

feat(fw,tests): change EOF to stack_height_increase #1393

chfast merged 1 commit into from
Apr 14, 2025

Conversation

@chfast
Copy link
Member

@chfast chfast commented Apr 3, 2025 •
edited
Loading

🗒️ Description

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
@chfast chfast added scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature scope:fw Scope: Framework (evm|tools|forks|pytest) labels Apr 3, 2025
@chfast chfast force-pushed the eof/stack_height_increase branch 2 times, most recently from 4a9387f to 0a34b50 Compare April 3, 2025 12:08
@chfast chfast mentioned this pull request Apr 3, 2025
Closed
5 tasks
@chfast chfast force-pushed the eof/stack_height_increase branch from 0a34b50 to 9c99efc Compare April 7, 2025 07:58
@chfast chfast mentioned this pull request Apr 7, 2025
Merged
8 tasks
@chfast chfast force-pushed the eof/stack_height_increase branch from 9c99efc to a71be92 Compare April 8, 2025 13:36
@chfast chfast requested review from gumb0, marioevz and pdobacz April 8, 2025 14:19
@chfast chfast marked this pull request as ready for review April 8, 2025 14:22
pdobacz
pdobacz reviewed Apr 9, 2025
View reviewed changes
@chfast chfast force-pushed the eof/stack_height_increase branch 2 times, most recently from 8d42af7 to 8d8deac Compare April 10, 2025 08:00
@chfast chfast force-pushed the eof/stack_height_increase branch from 8d8deac to 3ae7e5c Compare April 11, 2025 11:37
@shemnon
Copy link
Collaborator

shemnon commented Apr 11, 2025

Besu passes at 100% on this fork: https://github.com/shemnon/besu/tree/eof-devnet-1

LGTM
@spencer-tb spencer-tb added the fork:osaka Osaka hardfork label Apr 14, 2025
@chfast chfast merged commit a1c4eef into ethereum:main Apr 14, 2025
11 checks passed
@chfast chfast deleted the eof/stack_height_increase branch April 14, 2025 09:20
@spencer-tb spencer-tb added feature:eof and removed fork:osaka Osaka hardfork labels Apr 29, 2025
pacrob pushed a commit to pacrob/execution-spec-tests that referenced this pull request May 5, 2025
@chfast @pacrob
feat(fw,tests): change EOF to max_stack_increase (ethereum#1393)
b94a507
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
@chfast @felix314159
feat(fw,tests): change EOF to max_stack_increase (ethereum#1393)
2e13f73
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
@chfast
feat(fw,tests): change EOF to max_stack_increase (ethereum#1393)
0b88e58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:eof scope:fw Scope: Framework (evm|tools|forks|pytest) scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature

4 participants

@chfast @shemnon @pdobacz @spencer-tb