Skip to content

Conversation

@tmythicator
Copy link
Contributor

@tmythicator tmythicator commented Jan 29, 2019

According to Issue #42.
I am quite new to Elisp and Lisp in general, so further corrections are welcomed! 😄

(interactive)
(solidity--start-gasestimate (thing-at-point 'symbol 'no-properties)))

;;; Support for imenu
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @atimchenko92. Thank you very much. My colleague @rakanalh who uses Imenu tested it and it works.

I have one request only. Can you add a changelog entry here? Something like:
"Added support for Imenu".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added entry to changelog as well. My pleasure! :)

@LefterisJP
Copy link
Collaborator

Hey @atimchenko92 can you rebase the last merge commit away? It should not be needed.

@tmythicator
Copy link
Contributor Author

Now it should be good

@LefterisJP
Copy link
Collaborator

@atimchenko92 yep! Thank you. Much appreciated.

@LefterisJP LefterisJP merged commit 0d3cdcd into ethereum:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants