Code quality #21
Open
Code quality #21
+181 −149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
... with the ability to pass a newer standard.
…able "Universally" means that macros or types the library needs throughout the code base are available from the very beginning without including the config over again.
Code analysis according to the MISRA Standard requires marking constructors `explicit` or `explicit(false)`.
eteran requested changes Nov 16, 2025
| @@ -0,0 +1,11 @@ | |||
| #pragma once | |||
Owner
There was a problem hiding this comment.
I know it's ubiquitous, but I do tend to avoid #pragma once since it's non-standard.
Contributor Author
There was a problem hiding this comment.
OK, I find this quite stringent, as all compilers support it. However, I respect your decision.
Contributor Author
There was a problem hiding this comment.
I would then also rename the header guards from JSON_* -> CPP_JSON_* to be as independent as possible with regard to name clashes. Is that alright?
| | ||
| public: | ||
| parser(std::string_view s) | ||
| CPP_JSON_EXPLICIT_IF(false) parser(std::string_view s) |
Owner
There was a problem hiding this comment.
I would actually make this constructor plain old explicit.
Owner
| Only a couple of nit-picks this time ;-) Thanks for the PR! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR brings the following updates:
json.hheader file. It is located in a subfolder called “functional” because it provides functional elements internal to cpp-json.explicit(false). Some code analysis standards like MISRA require to be explicit about it.json::valuecan use the default copy/move constructors and assignment operators.JSON_THROW->CPP_JSON_THROWto avoid potential naming conflicts.std::*_talias templates andstd::*_vvariable templates everywhere.