Underlying unicode char types, updates to JSON reader #18
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Originally i set out to correct a warning about
snprintf()requiring anunsigned intwhen passed achar32_t.So this PR fixes this warning and more:
char->unsigned char,char8_t->unsigned char,char16_t->std::uint_least16_t,char32_t->std::uint_least32_t.json::basic_reader<>::match()due to accessing the character array past-the-end.json::basic_reader<>::match_any().json::basic_reader<>with string_view functionality or iterator logic.noexceptspecifier to lambda functions passed tojson::basic_reader<>::consume_while().sizeofwithstd::size()when passing character buffer size.Additionally: