Skip to content

Conversation

@SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Oct 5, 2023

Description of Change

This PR follows #8600 and #8562 changes for all necessary variant files / boards.txt.
It also fixes the #8560 issue in the Arduino Core 3.0.0
The PR moves common macros and defines to Arduino.h, not necessary in pins_arduino.h file anymore.
It also adds NEO_LED macros and constants in order to allow using it in a digitalWrite() for Blinking as in the example:
https://github.com/espressif/arduino-esp32/blob/master/libraries/ESP32/examples/GPIO/BlinkRGB/BlinkRGB.ino

Tests scenarios

Passed boards CI https://github.com/SuGlider/arduino-esp32/actions/runs/6425347486

Testing compilation of a sketch using the new Arduino.h and its changes:

void setup() { int a = NUM_DIGITAL_PINS; int b = NUM_ANALOG_INPUTS; int c = EXTERNAL_NUM_INTERRUPTS; int d = analogInputToDigitalPin(1); int e = digitalPinToInterrupt(2); bool f = digitalPinHasPWM(3); } void loop() { }

Tested the sketch from #8560

// Not a working sketch - Using ESP32-S3 void IRAM_ATTR Callback() { } void setup() { //This does not work: attachInterrupt(digitalPinToInterrupt(48), Callback, FALLING); //This works: attachInterrupt(48, Callback, FALLING); }

Related links

Fix #8560

@SuGlider SuGlider added this to the 3.0.0 milestone Oct 5, 2023
@SuGlider SuGlider self-assigned this Oct 5, 2023
@SuGlider SuGlider marked this pull request as draft October 5, 2023 19:40
@SuGlider
Copy link
Collaborator Author

SuGlider commented Oct 5, 2023

Finishing more board pins_arduino.h review

@SuGlider
Copy link
Collaborator Author

SuGlider commented Oct 5, 2023

Final test with Git Action Board Test is OK
https://github.com/SuGlider/arduino-esp32/actions/runs/6425347486

@SuGlider SuGlider added the Status: Pending Merge Pull Request is ready to be merged label Oct 5, 2023
@SuGlider SuGlider marked this pull request as ready for review October 5, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Pending Merge Pull Request is ready to be merged

3 participants