WiFi Should Reconnect For Most Reasons #7344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1 task
mrengineer7777 force-pushed the WiFiReconnect branch from f548ba8 to 282f968 Compare | Still looking for feedback on this PR |
1 task
| I have been running the reconnect logic for 3 weeks on my project with no issues. Submitting for review. |
| @mrengineer7777 Thanks for update, I asked Devs for help with review. |
me-no-dev approved these changes Nov 7, 2022
PilnyTomas approved these changes Nov 7, 2022
This was referenced Nov 7, 2022
| Thanks @mrengineer7777 for this PR! |
Closed
3 tasks
| This should be reverted ASAP #7968 |
| @tablatronix I strongly disagree. This PR fixed connection issues for multiple users. Your issue is with specific routers. The fix will likely have to be in the WiFi driver in IDF repository. Please keep your comments on the open issue. |
| Not router specific, this is the standard response for all WPA password failures that I tested, rather the PR fix is for non standard behaviors |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description of Change
Allows WiFi to reconnect for most disconnect reasons. See #7210 for discussion.
Tests scenarios
ESP32-WROOM-32UE (4MB) on custom PCB. Similar pinout to Adafruit FeatherESP32 (Huzzah32).
Tested changes on platform=
https://github.com/tasmota/platform-espressif32/releases/download/v2.0.3/platform-espressif32-2.0.3.zip. WORKS!
https://github.com/tasmota/platform-espressif32/releases/download/v2.0.5/platform-espressif32-2.0.5.zip WORKS!
Related links
Closes #7210
Closes #7296