fix: compiler warnings about printf-format for pointers in esp32-hal-cpu.c #6705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
warning was: ``` framework-arduinoespressif32/cores/esp32/esp32-hal-cpu.c:132:9: note: in expansion of macro 'log_e' log_e("not found func=%08X arg=%08X",cb,arg); ^~~~~ framework-arduinoespressif32/tools/sdk/esp32/include/log/include/esp_log.h:276:27: warning: format '%X' expects argument of type 'unsigned int', but argument 7 has type 'void *' [-Wformat=] ``` 
format-str expected plain uint while `duration` is long-uint. Warning was: ``` .../cores/esp32/esp32-hal-log.h:115:32: note: in expansion of macro 'ESP_LOG_LEVEL_LOCAL' #define log_d(format, ...) do {ESP_LOG_LEVEL_LOCAL(ESP_LOG_DEBUG, TAG, format, ##__VA_ARGS__);}while(0) ^~~~~~~~~~~~~~~~~~~ .../cores/esp32/Tone.cpp:31:9: note: in expansion of macro 'log_d' log_d("Task received from queue TONE_START: _pin=%d, frequency=%u Hz, duration=%u ms", tone_msg.pin, tone_msg.frequency, tone_msg.duration); ^~~~~ .../tools/sdk/esp32/include/log/include/esp_log.h:276:27: warning: format '%u' expects argument of type 'unsigned int', but argument 8 has type 'long unsigned int' [-Wformat=] ``` 
| Discovered another x2 issues in
|
| Thanks @ankostis :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
the compiler complains about these 2 places in
esp32-hal-cpu.cppof miss-matching %X to function & void pointers,and x2 in
Tone.cppmiss-matchinguintwith `long uint.Sample warning messages:
I believe the correct should be
%p, but i preserved the 8-width in my PR.(cannot really test the code, this fix just stops the compiler warnings).
Steps to Reproduce
To get those warnings, i had to enable
-Wformatbuild-flag and defineDUSE_ESP_IDF_LOG 1,so the esp_idf log-routines to apply, that they are appropriately marked with
__attribute__ (( format(...) ))).