Skip to content

Add CI job which tries to build arduino-esp32 as a component #5842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 26, 2022
Merged

Add CI job which tries to build arduino-esp32 as a component #5842

merged 8 commits into from
Apr 26, 2022

Conversation

@igrr
Copy link
Member

@igrr igrr commented Nov 3, 2021

Summary

This PR is related to #5839.

  • This PR adds an IDF version check to arduino-esp32 component CMakeLists file. IDF version is checked against the range of supported versions. If the version is not supported, an error is reported.

    This check can be bypassed by arduino-esp32 developers by setting an environment variable, see comments in the source code.

  • This PR also adds a CI job which tries to build arduino-esp32 as a component. The CI job currently runs on the latest release/v4.4 branch of IDF via the official Docker image. When new chips or supported versions are added, build matrix can be adjusted.

Impact

  • Building with an unsupported version of IDF will now fail at configuration stage, even if it could succeed previously.
  • CI might fail if there are regressions in IDF release branch; on the other hand, we will know about that sooner and will address these failures, waiting until users report them.
@igrr igrr requested a review from me-no-dev November 3, 2021 16:30
@igrr igrr force-pushed the feature/idf_component_ci_and_ver_check branch 2 times, most recently from c13f707 to 844a579 Compare November 3, 2021 16:41
@igrr igrr force-pushed the feature/idf_component_ci_and_ver_check branch 2 times, most recently from ae053e7 to 09b2f35 Compare November 3, 2021 17:09
atanisoft
atanisoft reviewed Nov 3, 2021
View reviewed changes
@igrr igrr force-pushed the feature/idf_component_ci_and_ver_check branch from 09b2f35 to 1b41380 Compare November 3, 2021 19:11
@igrr igrr force-pushed the feature/idf_component_ci_and_ver_check branch from 1b41380 to b65b956 Compare November 3, 2021 19:26
me-no-dev
me-no-dev reviewed Nov 4, 2021
View reviewed changes
.github/workflows/push.yml
python-version: '3.x'
- name: Build Sketches
run: bash ./.github/scripts/on-push.sh 1 1 #equal and non-zero to trigger PIO

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good test, but I am not sure if it is necessary to run with each push. In what cases/changes will this fail, but not fail in the sketch tests? Maybe we can limit it to changes on particular files? I also noticed in the logs that Arduino was not actually built. Probably issue with the extra components path.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe CMakeLists.txt and Kconfig.projbuild are a good option for filter?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about running this for master branch only?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but still what would be the benefit compared to the lib-builder doing this every 6 hours? Make sure that Arduino will build without any other submodules and default config?
@me-no-dev me-no-dev changed the title Add IDF version check when building as IDF component, add CI job Add CI job which tries to build arduino-esp32 as a component Nov 9, 2021
@igrr igrr mentioned this pull request Nov 28, 2021
Closed
@VojtechBartoska VojtechBartoska mentioned this pull request Jan 31, 2022
Closed
4 tasks
@VojtechBartoska VojtechBartoska added the Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure. label Feb 2, 2022
@stale stale bot added the wontfix label Apr 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2022 •
edited
Loading

Unit Test Results

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 08b6363.

♻️ This comment has been updated with latest results.
@espressif espressif deleted a comment from stale bot Apr 20, 2022
@me-no-dev me-no-dev merged commit f60cd8a into master Apr 26, 2022
@me-no-dev me-no-dev deleted the feature/idf_component_ci_and_ver_check branch April 26, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure.

5 participants

@igrr @atanisoft @me-no-dev @VojtechBartoska