Allow passing custom HTTPClient to HTTPUpdate #4959
Conversation
This enables customizing HTTP headers and adds some extra flexibility.
| Wouldn't it make sense to just add something like |
| @me-no-dev Well, why not. I pushed this edit as you suggested. |
| return handleUpdate(http, currentVersion, false); | ||
| } | ||
| | ||
| HTTPUpdateResult HTTPUpdate::updateSpiffs(HTTPClient& httpClient, const String& url, const String& currentVersion) |
There was a problem hiding this comment.
Does not need the url argument :)
| t_httpUpdate_return update(HTTPClient& httpClient, const String& host, uint16_t port, const String& uri = "/", | ||
| const String& currentVersion = ""); | ||
| | ||
| t_httpUpdate_return updateSpiffs(HTTPClient &httpClient, const String &url, const String ¤tVersion = ""); |
There was a problem hiding this comment.
Does not need the url argument :)
| return handleUpdate(http, currentVersion, true); | ||
| } | ||
| | ||
| HTTPUpdateResult HTTPUpdate::update(HTTPClient& httpClient, const String& host, uint16_t port, const String& uri, |
There was a problem hiding this comment.
Does not need the host, port and uri arguments :)
| | ||
| t_httpUpdate_return updateSpiffs(WiFiClient& client, const String& url, const String& currentVersion = ""); | ||
| | ||
| t_httpUpdate_return update(HTTPClient& httpClient, const String& host, uint16_t port, const String& uri = "/", |
There was a problem hiding this comment.
Does not need the host, port and uri arguments :)
| you forgot to remove some arguments there :) |
These arguments are not required when passing the HTTPClient instead of WiFiClient.
| @me-no-dev oh sorry! I did that it in parallel with other work. I removed these redundant arguments. This should be fine now. |
| Thanks :) all good now! |
2 participants
This enables customizing HTTP headers which adds some extra flexibility.
This does not break anything of course because this change introduces a new constructor with a new additional HTTPClient argument for HTTPUpdate class.