Defined BLE setAdvertisementType #3535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
chegewara approved these changes Dec 3, 2019
| @chegewara Shouldn't this be added to https://github.com/nkolban/esp32-snippets/tree/master/cpp_utils, because the library is maintained in the nkolban/esp32-snippets repo? And then sync the library as described in https://github.com/nkolban/esp32-snippets/blob/master/cpp_utils/ArduinoBLE.md#replacing-the-version-that-comes-with-arduino-esp32 back to this repo. Currently the libraries are out of sync. For example the |
| Currently arduino BLE library and cpp_utils are separate libraries. If there is something that is missing in arduino, but exists in cpp_utils feel free to create PR here. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently we have no way to set BLE Advertisement Type.
We have an initial value of
ADV_TYPE_INDand the member is private.iBeacon should advertise with
ADV_TYPE_NONCONN_IND.esp-idf's example code specifies this value.
https://github.com/espressif/esp-idf/blob/93a8603c545fb8e54741d6685146e2f3b874378d/examples/bluetooth/bluedroid/ble/ble_ibeacon/main/ibeacon_demo.c#L57