Skip to content

WString explicit converters to reduce Flash size #3497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 20, 2020
Merged

WString explicit converters to reduce Flash size #3497

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27aa29b
WString explicit converters to reduce Flash size
everslick Nov 19, 2019
2ae72c6
Update WString.h
everslick Nov 19, 2019
4846d9c
Update WString.h
everslick Nov 19, 2019
6150ef3
Merge branch 'master' into everslick-patch-1
me-no-dev Jan 20, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update WString.h
  • Loading branch information
@everslick
everslick authored Nov 19, 2019
commit 2ae72c62fa827276ad4bcc40ebb5200aab5a6dd8
12 changes: 6 additions & 6 deletions cores/esp32/WString.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,11 +203,11 @@ class String {
unsigned char equalsIgnoreCase(const String &s) const;
unsigned char equalsConstantTime(const String &s) const;
unsigned char startsWith(const String &prefix) const;
unsigned char startsWith(const char *prefix) const {
unsigned char startsWith(const char *prefix) const {
 return this->startsWith(String(prefix));
 }
 unsigned char startsWith(const __FlashStringHelper * prefix) const {
 return this->startsWith(String(prefix));
 unsigned char startsWith(const __FlashStringHelper *prefix) const {
return this->startsWith(String(prefix));
 }
unsigned char startsWith(const String &prefix, unsigned int offset) const;
unsigned char endsWith(const String &suffix) const;
Expand All @@ -217,7 +217,7 @@ class String {
 unsigned char endsWith(const __FlashStringHelper *suffix) const {
 return this->endsWith(String(suffix));
 }

// character access
char charAt(unsigned int index) const;
void setCharAt(unsigned int index, char c);
Expand Down Expand Up @@ -251,11 +251,11 @@ class String {
// modification
void replace(char find, char replace);
void replace(const String &find, const String &replace);
void replace(const char *find, const String &replace) {
void replace(const char *find, const String &replace) {
 this->replace(String(find), replace);
 }
 void replace(const __FlashStringHelper *find, const String &replace) {
 this->replace(String(find), replace);
 this->replace(String(find), replace);
 }
 void replace(const char *find, const char *replace) {
 this->replace(String(find), String(replace));
Expand Down