Fix HTTPUpdate flash size check and add SPIFFS size check #2161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits December 5, 2018 13:59
…_rxBuffer is not initialised
This was referenced Dec 5, 2018
Merged
me-no-dev reviewed Dec 6, 2018
| | ||
| // To do: the SHA256 could be checked if the server sends it | ||
| | ||
| delay(0); |
me-no-dev reviewed Dec 6, 2018
| } else { | ||
| if(len > (int) ESP.getFreeSketchSpace()) { | ||
| log_e("FreeSketchSpace to low (%d) needed: %d\n", ESP.getFreeSketchSpace(), len); | ||
| const esp_partition_t* _partition = esp_ota_get_next_update_partition(NULL); |
There was a problem hiding this comment.
please move this logic to Esp.cpp and replace the one in ESP.getFreeSketchSpace. What is currently there makes no sense for any use.
There was a problem hiding this comment.
Moving to ESP.cpp, replacing getFreeSketchSpace() with new code, in HTTUpdate.cpp calling getFreeSketchSpace() again.
| Nice :) thanks! |
| You're welcome! :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
HTTPUpdate checked if the new sketch would fit into the current partition free space, which was wrong. Now it checks if it fits into the next flash partition.
A size check for a SPIFFS update is added, this was stil 'to do' from the previous PR.
Still to do: the SHA256 hash could be checked if a server sends it in the request header.
This PR includes PR #2155.