Enable pulseIn() #140
Merged
Enable pulseIn() #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
enable pulseIn()
me-no-dev reviewed Jan 20, 2017
cores/esp32/wiring_pulse.c Outdated
| if (xthal_get_ccount() - start_cycle_count > timeout_cycles) { \ | ||
| return 0; \ | ||
| } \ | ||
| optimistic_yield(5000); \ |
There was a problem hiding this comment.
optimistic_yield no longer needed
| did you test this? |
| Yes, I have it running on my desk right now. I can remove the optimistic_yield. |
| Okay, my latest commit, has removed the optimistic_yield |
brentru added a commit to adafruit/arduino-esp32 that referenced this pull request Oct 22, 2024
Add platform Adafruit Feather ESP32-S3 TFT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
quick edit to make pulseIn() work.