SDK headers: Use new esp-idf signal name VSPICLK_OUT_IDX #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I have this prepped as well :) Just did not get to rebuilding, though you are correct to say that it is not required :) simple define change does. |
brentru added a commit to adafruit/arduino-esp32 that referenced this pull request Oct 22, 2024
Fix ESP32-S3 UF2 generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi @me-no-dev,
esp-idf commit esp-idf/23455de4 renamed VSPICLK_OUT_MUX_IDX to VSPICLK_OUT_IDX. This PR updates the name to avoid compilation errors when using arduino as an esp-idf component.
FWIW I think this should be safe to change even without rebuilding the binary libraries, as there's no object file difference. But it will break anyone compiling arduino as a submodule in older esp-idf.
Angus