fix(eth): Fix RMII Ethernet not being able to be restarted #11048
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
ETHClass::begin
method in thelibraries/Ethernet/src/ETH.cpp
file. The main purpose of these changes is to improve the initialization process of the Ethernet MAC and PHY by storing the created instances in class member variables instead of local variables.Initialization improvements:
mac
variable to a class member variable_mac
and updated the error handling to use_mac
.phy
variable to a class member variable_phy
and updated the error handling to use_phy
._phy
instead ofphy
.eth_config
initialization to use the class member variables_mac
and_phy
instead of the local variablesmac
andphy
.