fix flashinit panic not printing

[mhightower83]

Resolves

• Panic in flashinit fails to generate stack dump #8761 (comment)

[mcspr]

Just as a thought, don't we want to return something like this?

FlashInitResult flashinit();

struct FlashInitResult { bool ok { false }; const char* err_msg; };

[d-a-v]

flashinit() was not designed to fail, so it is 'panic'ing instead

edit: my bad, I was some merged PRs late

[mhightower83]

Too many merge conflicts were corrected with web edit, I need to correct some stuff and do a few real tests.

[mcspr]

flashinit() was not designed to fail, so it is 'panic'ing instead

I just mean the return value. Struct member name tells us what we mean right there, no need to remember triple meaning of a char pointer

[mhightower83]

FlashInitResult flashinit();

FWIF: I tried this method and it increases "IROM code in flash" by 16 bytes.

[mcspr]

FlashInitResult flashinit();

FWIF: I tried this method and it increases "IROM code in flash" by 16 bytes.

Suppose, bool could go, but methods could do the thing instead

#include <cstdio> void __panic_func(const char* file, int line, const char* func) { printf("panic! at %s:%d::%s\n", file, line, func); } struct SimpleResult { SimpleResult() = default; constexpr SimpleResult(const char* error) : _error(error) {} bool ok() const { return _error == nullptr; } const char* error() const { return _error; } // or, other order, depends on whats more important to replace void check(const char* file = __builtin_FILE(), int line = __builtin_LINE(), const char* func = __builtin_FUNCTION()) { if (!ok()) { __panic_func(file, line, func); } } private: const char* _error { nullptr }; }; int main() { SimpleResult what{"oops"}; what.check(); }