Skip to content

Generic netif status callback and mDNS #8705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2022
Merged

Generic netif status callback and mDNS #8705

merged 2 commits into from
Nov 1, 2022

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Oct 31, 2022

follow up #8676

  • sprinkle IPAddress(...).isSet() across our loops to avoid polling on a stopped interface. status callback and netif_is_up does not guarantee and we could use the interface!
  • register one status callback per instance, e.g. when begin() is called multiple times (also notice a subtle issue with schedule function when instance is delete'ed)
  • consistent LwipIntf callback signature. no need for rvalue, just pass stdfunc as-is and let the compiler figure it out
mcspr added 2 commits November 1, 2022 02:44
@mcspr
Generic netif status callback and mDNS
9c8f45f 
* sprinkle IPAddress(...).isSet() across our loops to avoid polling on a stopped interface. status callback and netif_is_up **does not guarantee and we could use the interface**! * register *one* status callback per instance, e.g. when begin() is called multiple times (also notice a subtle issue with schedule function when instance is delete'ed) * consistent LwipIntf callback signature. no need for rvalue, just pass stdfunc as-is and let the compiler figure it out
@mcspr
werror
0d007e0
@mcspr mcspr merged commit 04494f0 into esp8266:master Nov 1, 2022
@mcspr mcspr deleted the lwip/status-cb branch November 1, 2022 00:01
@mcspr mcspr added this to the 3.1 milestone Nov 2, 2022
This was linked to issues Dec 14, 2022
More for fixing MDNS #8675
Closed
mDNS not working with WiFi.mode(WIFI_AP_STA) on current git #8308
Closed
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request Nov 18, 2024
@mcspr @hasenradball
Generic netif status callback and mDNS (esp8266#8705)
43118f1 
* sprinkle IPAddress(...).isSet() across our loops to avoid polling on a stopped interface. status callback and netif_is_up **does not guarantee and we could use the interface**! * register *one* status callback per instance, e.g. when begin() is called multiple times (also notice a subtle issue with schedule function when instance is delete'ed) * consistent LwipIntf callback signature. no need for rvalue, just pass stdfunc as-is and let the compiler figure it out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@mcspr