Skip to content

do not call tcp/udp ::stopAll() when it is not required to do so #8598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2022
Merged

do not call tcp/udp ::stopAll() when it is not required to do so #8598

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f3690b
do not call tcp/udp ::stopAll() when it is not required to to so
d-a-v Jun 12, 2022
ac94867
remove stopAll also from ArduinoOTA
d-a-v Jun 23, 2022
f9b0ddf
Merge branch 'master' into nostopall
d-a-v Jun 23, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions libraries/ArduinoOTA/ArduinoOTA.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,6 @@ void ArduinoOTAClass::_runUpdate() {
delay(100);

Update.setMD5(_md5.c_str());
WiFiUDP::stopAll();
WiFiClient::stopAll();

if (_start_callback) {
_start_callback();
Expand Down
1 change: 0 additions & 1 deletion libraries/ESP8266HTTPUpdateServer/src/ESP8266HTTPUpdateServer-impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ void ESP8266HTTPUpdateServerTemplate<ServerType>::setup(ESP8266WebServerTemplate
return;
}

WiFiUDP::stopAll();
if (_serial_output)
Serial.printf("Update: %s\n", upload.filename.c_str());
if (upload.name == "filesystem") {
Expand Down
1 change: 0 additions & 1 deletion libraries/ESP8266WiFi/src/ESP8266WiFiGeneric.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,6 @@ void ESP8266WiFiGenericClass::_eventCallback(void* arg)

if(event->event == EVENT_STAMODE_DISCONNECTED) {
DEBUG_WIFI("STA disconnect: %d\n", event->event_info.disconnected.reason);
WiFiClient::stopAll();
}

if (event->event == EVENT_STAMODE_AUTHMODE_CHANGE) {
Expand Down