Skip to content

WString: unify numeric conversion and fix assignments #8526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 5, 2022
Merged

WString: unify numeric conversion and fix assignments #8526

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1b56cb2
WString: unify numeric conversion and fix assignments
mcspr Mar 30, 2022
a192705
cannot assign to uninitialized obj, try to placement-new replace the …
mcspr Mar 30, 2022
7e67800
mention the abundance of init()
mcspr Mar 30, 2022
16dff0e
implement host test
mcspr Mar 30, 2022
0ca7702
oops
mcspr Mar 30, 2022
4206518
trying to reduce the instances of where we specify the default base /…
mcspr Mar 30, 2022
44c8a24
use pointer from the func, don't default to the &buf[0]
mcspr Mar 31, 2022
d963949
hint about the length of the buffer
mcspr Mar 31, 2022
9ce12d1
Merge branch 'master' into arduino-string-can-assign-stuff
mcspr Apr 5, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
oops
  • Loading branch information
@mcspr
mcspr committed Mar 30, 2022
commit 0ca77028bf268ebaaef63f805553d4edf7e1dcdb
68 changes: 33 additions & 35 deletions cores/esp8266/WString.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,51 +202,49 @@ String::String(String &&rval) noexcept {
move(rval);
}

// placement new is safe enough, but be wary when `this` has something in the hierarchy
String::String(unsigned char value, unsigned char base) :
String(toString(value, base))
{}

String::String(unsigned char value, unsigned char base) {
new (this) String(toString(value, base));
}

String::String(int value, unsigned char base) {
new (this) String(toString(value, base));
}
String::String(int value, unsigned char base) :
String(toString(value, base))
{}

String::String(unsigned int value, unsigned char base) {
new (this) String(toString(value, base));
}
String::String(unsigned int value, unsigned char base) :
String(toString(value, base))
{}

String::String(long value, unsigned char base) {
new (this) String(toString(value, base));
}
String::String(long value, unsigned char base) :
String(toString(value, base))
{}

String::String(unsigned long value, unsigned char base) {
new (this) String(toString(value, base));
}
String::String(unsigned long value, unsigned char base) :
String(toString(value, base))
{}

String::String(long long value, unsigned char base) {
new (this) String(toString(value, base));
}
String::String(long long value, unsigned char base) :
String(toString(value, base))
{}

String::String(long long value) {
new (this) String(toString(value));
}
String::String(long long value) :
String(toString(value))
{}

String::String(unsigned long long value, unsigned char base) {
new (this) String(toString(value, base));
}
String::String(unsigned long long value, unsigned char base) :
String(toString(value, base))
{}

String::String(unsigned long long value) {
new (this) String(toString(value));
}
String::String(unsigned long long value) :
String(toString(value))
{}

String::String(float value, unsigned char decimalPlaces) {
new (this) String(toString(value, decimalPlaces));
}
String::String(float value, unsigned char decimalPlaces) :
String(toString(value, decimalPlaces))
{}

String::String(double value, unsigned char decimalPlaces) {
new (this) String(toString(value, decimalPlaces));
}
String::String(double value, unsigned char decimalPlaces) :
String(toString(value, decimalPlaces))
{}

/*********************************************/
/* Memory Management */
Expand Down