Skip to content

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Feb 20, 2022

Remove using namespace fs; from SDFS.h
Fix everything that depended on it

As noticed in the #8483

Remove `using namespace fs;` from SDFS.h Fix everything that depended on it
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I got a little lazy in writing the original code, thanks for cleaning it up!

@earlephilhower earlephilhower merged commit ead5f94 into esp8266:master Feb 23, 2022
@mcspr mcspr deleted the no-global-using-fs branch January 7, 2023 00:18
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request Nov 18, 2024
Remove `using namespace fs;` from SDFS.h Fix everything that depended on it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants