Skip to content

Release process fix #2 #8127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 16, 2021
Merged

Release process fix #2 #8127

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
053016e
release script: fix variable name error
d-a-v Jun 16, 2021
f543f21
Release process in README is decribed twice. Syncing the two walk-thr…
d-a-v Jun 16, 2021
ba5b719
adding ARDUINO_ESP8266_VERSION reflecting exactly what's passed to `m…
d-a-v Jun 16, 2021
b5998b3
remove "unix-" in version name (which was present even for windows bu…
d-a-v Jun 16, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adding ARDUINO_ESP8266_VERSION reflecting exactly what's passed to `m… 
…akecorever.py -v`
  • Loading branch information
@d-a-v
d-a-v committed Jun 16, 2021
commit ba5b7198782f183b614134ffeacf43a73d184bdf
3 changes: 2 additions & 1 deletion tools/makecorever.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ def git(*args):
pass

text += "#define ARDUINO_ESP8266_GIT_DESC {}\n".format(git_desc)
text += "#define ARDUINO_ESP8266_VERSION {}\n".format(version)
text += "\n"

version_split = version.split(".")
Expand All @@ -62,7 +63,7 @@ def git(*args):
text += "#define ARDUINO_ESP8266_REVISION {}\n".format(revision[0])
text += "\n"

# release or dev
# release or dev ?
if release:
text += "#define ARDUINO_ESP8266_RELEASE \"{}\"\n".format(git_desc)
text += "#define ARDUINO_ESP8266_RELEASE_{}\n".format(git_desc.replace("-","_").replace(".","_"))
Expand Down