Skip to content

Full consolidation of "phase locking" and "PWM locking" waveform generators #8011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Full consolidation of "phase locking" and "PWM locking" waveform generators #8011

wants to merge 16 commits into from

Conversation

dok-net
Copy link
Contributor

@dok-net dok-net commented May 1, 2021 •
edited
Loading

This now needs review and testing.
At time of publishing, the following MCVE works for eyes and ears, not tested with an oscilloscope by myself yet:

#include <PolledTimeout.h> #ifndef D5 #define D5 (14) #endif uint8_t brightness = 255; uint8_t brightnessAdj = 1; void setup() { tone(D5, 440, 3 * 2560); analogWrite(LED_BUILTIN, brightness); } esp8266::polledTimeout::periodicMs changeBrightness(10); void loop() { if (changeBrightness) { if (!brightness || !static_cast<uint8_t>(~brightness)) { brightnessAdj = ~brightnessAdj; ++brightnessAdj; } brightness += brightnessAdj; analogWrite(LED_BUILTIN, brightness); } }

Fixes #8081.
@dok-net dok-net force-pushed the mergepwm branch 5 times, most recently from 255baa3 to 1579b85 Compare May 1, 2021 20:38
@dok-net dok-net mentioned this pull request May 1, 2021
Merged
@dok-net dok-net force-pushed the mergepwm branch 7 times, most recently from 42089c6 to 24f77b9 Compare May 3, 2021 17:30
@dok-net dok-net changed the title [WIP] Full consolidation of "phase locking" and "PMW locking" waveform generators Full consolidation of "phase locking" and "PMW locking" waveform generators May 3, 2021
@dok-net dok-net force-pushed the mergepwm branch 7 times, most recently from c6b902b to 92d1d4a Compare May 19, 2021 08:34
@dok-net dok-net mentioned this pull request May 28, 2021
Closed
@dok-net dok-net force-pushed the mergepwm branch 6 times, most recently from 166f61f to 69448a9 Compare June 6, 2021 10:07
@dok-net dok-net force-pushed the mergepwm branch 2 times, most recently from d3d32a6 to a93d42e Compare September 2, 2021 05:46
@dok-net dok-net force-pushed the mergepwm branch 3 times, most recently from a2074bb to ddc6403 Compare October 19, 2021 05:32
@dok-net dok-net force-pushed the mergepwm branch 2 times, most recently from e4f6fa9 to abcf2cf Compare December 3, 2021 00:16
@dok-net dok-net force-pushed the mergepwm branch 3 times, most recently from 4ce0522 to 38eee50 Compare March 13, 2022 20:22
dok-net added 12 commits December 23, 2022 10:26
@dok-net
Pin has uint8_t, not int type.
b89932c
@dok-net
Can't image stopWaveform is called but PWM shall not stop.
2776d16 
startWaveform already implied stopping PWM before.
@dok-net
let analogWrite coexist with open-drain mode
98537bd
@dok-net
Don't force timer on PWM update as this is pulled by ISR, but only im…
36b2bd3 
…plemented on next PWM period begin anyway.
@dok-net
Correct shutdown sequence for phase-sync waveform generator in analog…
ff0782c 
…Write.
@dok-net
Correction to IRQ latency and ISR delta logic.
293f767
@dok-net
Early firing the ISR causes interruption to other waveforms, let it p…
50ded37 
…ick up new starts at next regular interval.
@dok-net
Stopping of the same pin always wins over starting.
f17ba7f
@dok-net
Clean code.
5de25bd
@dok-net
Prevent initial bad clock drift calculation on timer init.
6dbd371
@dok-net
stopWaveform in _setPWM caused unconditional _stopPWM.
d8893b0
@dok-net
Prevent inlining of initTimer()
9c612a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@dok-net