Skip to content

Conversation

earlephilhower
Copy link
Collaborator

@earlephilhower earlephilhower commented Jan 23, 2021

Add basic 24 bit mode to the I2S API with a i2s_set_bits() call.
By default 16b mode is still used, but if i2s_set_bits(24) is run
before i2s_begin() then the HW will drive 24-bits of data. This
data must be left-aligned (i.e. bits 31..8) in 4-byte samples.

Fixes #5244 (the HW doesn't support 8 or 32 bits, only 16 or 24).

Add basic 24 bit mode to the I2S API with a i2s_set_bits() call. By default 16b mode is still used, but if i2s_set_bits(24) is run before i2s_begin() then the HW will drive 24-bits of data. This data must be left-aligned (i.e. bits 31..8) in 4-byte samples.
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@earlephilhower earlephilhower merged commit e0cfb5a into esp8266:master Jan 23, 2021
@earlephilhower earlephilhower deleted the i2s24b branch January 23, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants