Fix newlib to support <+-nn> timezone names #7702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Undoes the change in esp8266#7699 and fixed esp8266#7690 root cause. Newlib did not support timezone names of the form "<[+-]?[0-9]+>" and would parse the offset using the <name>. Fix newlib tzset parser with earlephilhower/newlib-xtensa#14 and undo the UNK changes used as an expedient workaround.
d-a-v approved these changes Nov 12, 2020
There was a problem hiding this comment.
Works a treat !
(Tested with TZ_Antarctica_Troll)
09:26:55.334672968 timezone: <+00>0<+02>-2,M3.5.0/1,M10.5.0/3 ... 09:26:59.175711472 settimeofday(USER): future= 90days: DST=false - Wed Feb 10 08:26:59 2021 09:26:59.180575577 settimeofday(USER): future=120days: DST=false - Fri Mar 12 08:26:59 2021 09:26:59.188293866 settimeofday(USER): future=150days: DST=true - Sun Apr 11 10:26:59 2021 09:26:59.191907195 settimeofday(USER): future=180days: DST=true - Tue May 11 10:26:59 2021 09:26:59.195886107 settimeofday(USER): future=210days: DST=true - Thu Jun 10 10:26:59 2021 09:26:59.200487296 settimeofday(USER): future=240days: DST=true - Sat Jul 10 10:26:59 2021 09:26:59.206401418 settimeofday(USER): future=270days: DST=true - Mon Aug 9 10:26:59 2021 09:26:59.213774748 settimeofday(USER): future=300days: DST=true - Wed Sep 8 10:26:59 2021 09:26:59.215983952 settimeofday(USER): future=330days: DST=true - Fri Oct 8 10:26:59 2021 09:26:59.222587307 settimeofday(USER): future=360days: DST=false - Sun Nov 7 08:26:59 2021 earlephilhower/newlib-xtensa#15 Removed a couple lines of code and ensures that only TZs of the <..> form are accepted (i.e. ensure the terminal '>').
d-a-v approved these changes Nov 12, 2020
vortigont added a commit to DmytroKorniienko/EmbUI that referenced this pull request Nov 19, 2020
local WA for both esp8266 and esp32 'till fixed in both core's Fix for 8266 already in master esp8266/Arduino#7702 Signed-off-by: Emil Muratov <gpm@hotplug.ru>
vortigont added a commit to DmytroKorniienko/EmbUI that referenced this pull request Nov 19, 2020
local WA for both esp8266 and esp32 'till fixed in both core's Fix for 8266 already in master esp8266/Arduino#7702 Signed-off-by: Emil Muratov <gpm@hotplug.ru>
DmytroKorniienko added a commit to DmytroKorniienko/EmbUI that referenced this pull request Nov 26, 2020
commit d7917ef Author: Dmytro Korniienko <Dmytro.Korniienko@volo.global> Date: Thu Nov 26 18:37:06 2020 +0200 WiFi lost STA fix commit 768bb7a Author: Dmytro Korniienko <Dmytro.Korniienko@volo.global> Date: Thu Nov 26 17:40:10 2020 +0200 wifi manual reconnect fix commit b75e271 Author: Emil Muratov <gpm@hotplug.ru> Date: Wed Nov 25 20:29:02 2020 +0300 WiFi status fix - fixed updating WiFi station variable (ESP32) - Interface frame size increased for ESP32 Signed-off-by: Emil Muratov <gpm@hotplug.ru> commit 98d5eb1 Author: Emil Muratov <gpm@hotplug.ru> Date: Wed Nov 25 01:18:37 2020 +0300 Embed system settings vars/GUI - Add system-related vars to the embui initialization code - Predefined code for "settings' web-page - generic example changed to adopt predefined settings UI Signed-off-by: Emil Muratov <gpm@hotplug.ru> commit 86dc340 Author: Emil Muratov <gpm@hotplug.ru> Date: Thu Nov 19 16:55:27 2020 +0300 TimeLib: Workaround for newlib bug with <+-nn> timezone names local WA for both esp8266 and esp32 'till fixed in both core's Fix for 8266 already in master esp8266/Arduino#7702 Signed-off-by: Emil Muratov <gpm@hotplug.ru> commit a31bd32 Author: Emil Muratov <gpm@hotplug.ru> Date: Thu Nov 19 02:06:53 2020 +0300 WiFi: ESP32 DHCP WA, reconnection fix - implemented WA for the ESP32 issue espressif/arduino-esp32#2537 - Delayed reconnection, allows websocket to finish section transaction. Fix #1 Signed-off-by: Emil Muratov <gpm@hotplug.ru> commit b136f84 Author: Dmytro Korniienko <Dmytro.Korniienko@volo.global> Date: Fri Nov 6 18:47:48 2020 +0200 resources commit f276d20 Author: Dmytro Korniienko <Dmytro.Korniienko@volo.global> Date: Thu Nov 5 18:21:44 2020 +0200 mqtt critical fix commit fee53ef Author: Dmytro Korniienko <Dmytro.Korniienko@volo.global> Date: Thu Nov 5 16:19:42 2020 +0200 mqtt fix commit 803c9b6 Author: Dmytro Korniienko <Dmytro.Korniienko@volo.global> Date: Thu Nov 5 12:58:19 2020 +0200 resources fix commit be4bcb6 Author: Dmytro Korniienko <Dmytro.Korniienko@volo.global> Date: Thu Nov 5 12:15:58 2020 +0200 Upload progress fix commit 7e83cfc Author: Dmytro Korniienko <Dmytro.Korniienko@volo.global> Date: Wed Nov 4 17:47:12 2020 +0200 resources commit 81b3d5c Author: Dmytro Korniienko <Dmytro.Korniienko@volo.global> Date: Tue Nov 3 14:33:29 2020 +0200 MQTT log fix commit 1584fd8 Author: Emil Muratov <gpm@hotplug.ru> Date: Tue Nov 3 12:13:44 2020 +0300 OTA: esp8266 fix for gzipped fw image Signed-off-by: Emil Muratov <gpm@hotplug.ru> commit 208e6ec Merge: 3eff570 da552d7 Author: Emil Muratov <gpm@hotplug.ru> Date: Sat Oct 31 15:24:11 2020 +0300 Merge branch 'dev' of github.com:DmytroKorniienko/EmbUI into emdev commit 3eff570 Author: Emil Muratov <gpm@hotplug.ru> Date: Sat Oct 31 15:21:22 2020 +0300 OTA fix for ESP32 Signed-off-by: Emil Muratov <gpm@hotplug.ru> commit da552d7 Author: Dmytro Korniienko <Dmytro.Korniienko@volo.global> Date: Sat Oct 31 04:32:46 2020 +0200 bugfix mqtt commit cdaf07c Author: Dmytro Korniienko <Dmytro.Korniienko@volo.global> Date: Sat Oct 31 00:31:15 2020 +0200 bugfix commit 343649a Author: Dmytro Korniienko <Dmytro.Korniienko@volo.global> Date: Sat Oct 31 00:21:38 2020 +0200 getAPmac bugfix commit 0521889 Author: Dmytro Korniienko <Dmytro.Korniienko@volo.global> Date: Fri Oct 30 19:54:46 2020 +0200 bugfix commit 92f2907 Author: Dmytro Korniienko <Dmytro.Korniienko@volo.global> Date: Fri Oct 30 19:43:27 2020 +0200 Fix (lost changes)
vortigont added a commit to DmytroKorniienko/EmbUI that referenced this pull request Nov 28, 2020
local WA for both esp8266 and esp32 'till fixed in both core's Fix for 8266 already in master esp8266/Arduino#7702 Signed-off-by: Emil Muratov <gpm@hotplug.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Undoes the change in #7699 and fixed #7690 root cause.
Newlib did not support timezone names of the form "<[+-]?[0-9]+>" and
would parse the offset using the .
Fix newlib tzset parser with
earlephilhower/newlib-xtensa#14
and undo the UNK changes used as an expedient workaround.