Fix Error in hostByName with low timeout #7585
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Before,
aResult
was set toINADDR_NONE
, so255.255.255.255
(broadcast). When timeout was too low and callback didn't fire, theaResult.isSet()
line returned always true and that's not the correct behaviour.Even thought I'm not a native speaker,
INADDR_ANY
andINADDR_NONE
are confusing me.Whenever I think about it, I always associate
INADDR_NONE
with 0.0.0.0 andINADDR_ANY
with255.255.255.255
, but it's the other way.Also lwIP has the same scheme.
I would like to ask if we can add a
clear
method toIPAddress
like did toString
class (maybe in another PR) to resolve any doubts.