Skip to content

Unacceptable defaults that destroy servos #7023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 14, 2020
Merged

Unacceptable defaults that destroy servos #7023

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0827917
The default timings were chosen vastly outside specification. On COTS…
dok-net Jan 5, 2020
a2a1e0d
Change timing limits to safe values. With previous default timings an…
dok-net Jan 7, 2020
86caa07
Review action: revert changes to hard boundary for min/max duty cycle…
dok-net Jan 20, 2020
cc26161
A Servo on each available ESP8266 GPIO (D0-D8), no observed interfere…
dok-net Jan 20, 2020
e7695a9
Remove possible jerk due to force-cancelling duty cycle.
dok-net Feb 20, 2020
4c4906f
Overload attach: can specify initial angle for servo, too.
dok-net Feb 20, 2020
c551dc2
Stricter checks for configured, and default, bounded timings.
dok-net Mar 8, 2020
ac0f239
Missed the min/max in a comment.
dok-net Mar 8, 2020
ef33c5f
Default microsecond lower bound of 1000 causes confusing behavior - 2…
dok-net Mar 8, 2020
66933c1
Comment rationale for changed defaults of min/max pulse widths.
dok-net Oct 29, 2020
2f1e390
Merge branch 'master' into servo
earlephilhower Nov 14, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove possible jerk due to force-cancelling duty cycle.
  • Loading branch information
@dok-net
dok-net committed Oct 31, 2020
commit e7695a9e2a04b288d27f7ee38d73e1b1e3ca4f2f
3 changes: 2 additions & 1 deletion libraries/Servo/src/Servo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,11 @@ void Servo::detach()
{
if (_attached) {
_servoMap &= ~(1 << _pin);
startWaveform(_pin, 0, REFRESH_INTERVAL, 1);
delay(REFRESH_INTERVAL / 1000); // long enough to complete active period under all circumstances.
stopWaveform(_pin);
_attached = false;
_valueUs = DEFAULT_NEUTRAL_PULSE_WIDTH;
digitalWrite(_pin, LOW);
}
}

Expand Down