Skip to content

Remove memory leak on multiple calls to initCertStore #7021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2020
Merged

Remove memory leak on multiple calls to initCertStore #7021

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bd4993
Remove memory leak on multiple calls to initCertStore
earlephilhower Jan 17, 2020
d9e51ea
Merge branch 'master' into bsslcs
earlephilhower Jan 17, 2020
66758d1
Merge branch 'master' into bsslcs
earlephilhower Jan 17, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions libraries/ESP8266WiFi/src/CertStoreBearSSL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ int CertStore::initCertStore(FS &fs, const char *indexFileName, const char *data

_fs = &fs;

// In case initCertStore called multiple times, don't leak old filenames
free(_indexName);
free(_dataName);

// No strdup_P, so manually do it
_indexName = (char *)malloc(strlen_P(indexFileName) + 1);
_dataName = (char *)malloc(strlen_P(dataFileName) + 1);
Expand Down