Add LittleFS support to ESP8266WebServer.serveStatic() #6987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The previous implementation was based on a quirk of SPIFFS (that exists returns false for directories) so it wouldn't work with LittleFS. This implementation works with both.
earlephilhower approved these changes Jan 5, 2020
devyte approved these changes Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The problem was that the library was assuming that
FS::exists()would return false for directories, which is true for SPIFFS, but not for LittleFS. I changed the implementation to be compatible with both.I don't like using
fs.open(), but I couldn't find any better way to check if something is a directory or a file. If there is such a thing, please point me in the right direction and I will be happy to use that instead.