[BREAKING] polledTimeout: new remaining() returns time units until (next) expiration #6843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
devyte requested changes Nov 27, 2019
d-a-v reviewed Nov 27, 2019
dok-net force-pushed the polledTimeout_remaining branch from a361dec to 776f2a1 Compare dok-net changed the title dok-net force-pushed the polledTimeout_remaining branch from 996b469 to 47e82b1 Compare d-a-v reviewed Dec 4, 2019
dok-net force-pushed the polledTimeout_remaining branch from 4e284dc to f2a78ac Compare 
dok-net force-pushed the polledTimeout_remaining branch from f2a78ac to f33b2e0 Compare dok-net force-pushed the polledTimeout_remaining branch from f33b2e0 to a2166d8 Compare dok-net force-pushed the polledTimeout_remaining branch 2 times, most recently from 9f40cc1 to ab9d8f6 Compare dok-net force-pushed the polledTimeout_remaining branch 2 times, most recently from d636ed7 to 740670a Compare dok-net force-pushed the polledTimeout_remaining branch from 740670a to 6e02512 Compare dok-net force-pushed the polledTimeout_remaining branch from 6e02512 to df5c1e0 Compare dok-net force-pushed the polledTimeout_remaining branch from df5c1e0 to a4e89b5 Compare dok-net force-pushed the polledTimeout_remaining branch from a4e89b5 to 95eedb8 Compare dok-net force-pushed the polledTimeout_remaining branch from 95eedb8 to abed7f3 Compare dok-net force-pushed the polledTimeout_remaining branch from abed7f3 to 9f539f9 Compare dok-net force-pushed the polledTimeout_remaining branch from 9f539f9 to 0e812a6 Compare dok-net force-pushed the polledTimeout_remaining branch from 0e812a6 to ea24874 Compare dok-net force-pushed the polledTimeout_remaining branch 3 times, most recently from 098fd21 to 2c18f67 Compare dok-net changed the title dok-net force-pushed the polledTimeout_remaining branch 2 times, most recently from efe2ce5 to a4268a9 Compare … - that's wasted time. Expired keeps executing yield policy on already expired oneShot - that's counter intuitive and wasted time.
…and expiredRetrigger(). _oneShotExpired qualified as mutable member. This is done as intermediate fix for use in derived class ESP8266WiFiMesh ExpiringTimeTracker.
…onym for same function.
dok-net force-pushed the polledTimeout_remaining branch from 032f2d6 to 9430a39 Compare dok-net force-pushed the polledTimeout_remaining branch from 0ade799 to a0edd7d Compare | Superseded by #7960. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There are cases where the remaining time until the next expiration is needed.
remaining()returns that time value.Also prevent the call to
YieldPolicyT::execute()for expired timers, this looks like it generally just wastes time in needless delays.It's a breaking change due to the removal of
alwaysExpiredid0.