Skip to content

HTTPUpdateServer Allow external POSTS (CORS) #6824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 27, 2022
Merged

HTTPUpdateServer Allow external POSTS (CORS) #6824

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
461b413
HTTPUpdateServer Allow external POSTS (CORS)
joefran Nov 22, 2019
0aff839
Format Updates - POST HTTPUpdateServer
joefran Nov 22, 2019
56bdbaf
Merge branch 'master' into master
hookedupjoe Nov 23, 2019
b72dae9
Merge branch 'master' into master
hookedupjoe Dec 18, 2019
4f1b38a
Merge branch 'master' into master
earlephilhower Jan 13, 2021
1f83297
Merge branch 'master' into master
d-a-v Jun 15, 2022
f267dbc
Merge branch 'master' into master
d-a-v Jun 25, 2022
23157f0
Merge branch 'master' into master
d-a-v Jun 27, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions libraries/ESP8266HTTPUpdateServer/src/ESP8266HTTPUpdateServer-impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,24 @@ void ESP8266HTTPUpdateServerTemplate<ServerType>::setup(ESP8266WebServerTemplate
_server->send_P(200, PSTR("text/html"), serverIndex);
});

// handler for the /update form page - preflight options
_server->on(path.c_str(), HTTP_OPTIONS, [&](){
_server->sendHeader("Access-Control-Allow-Headers", "*");
_server->sendHeader("Access-Control-Allow-Origin", "*");
_server->send(200, F("text/html"), String(F("y")));
},[&](){
_authenticated = (_username == emptyString || _password == emptyString || _server->authenticate(_username.c_str(), _password.c_str()));
if(!_authenticated){
if (_serial_output)
Serial.printf("Unauthenticated Update\n");
return;
}
});

// handler for the /update form POST (once file upload finishes)
_server->on(path.c_str(), HTTP_POST, [&](){
_server->sendHeader("Access-Control-Allow-Headers", "*");
_server->sendHeader("Access-Control-Allow-Origin", "*");
if(!_authenticated)
return _server->requestAuthentication();
if (Update.hasError()) {
Expand Down