Pass String by const reference [3.0] #6583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dirkmueller force-pushed the string_cleanups_30 branch from 81a3e2f to 28c745c Compare 
earlephilhower approved these changes Oct 3, 2019
| The reason they're virtual is to allow a user to implement his own RequestHandler objects. |
devyte approved these changes Oct 3, 2019
| Actually, @devyte, while what you say is possible, IMO they're virtual because we need to store a pointer to a generic RequestHandler in the webserver (i.e. internal considerations, not custom overloads). Overloaded classes would suffer object slicing if we stored a pointer to the base class in the WebServer object, so these functions need to be virtual (even though I was able to rewrite the WebServer class to be a template w/o virtuals). |
Passing String by value means a full copy-constructor/temporary string creation which is slightly inefficient. Avoid that by using const references.
dirkmueller force-pushed the string_cleanups_30 branch from 28c745c to 561b7f4 Compare 
d-a-v approved these changes Jul 10, 2020
d-a-v reviewed Jul 10, 2020
| bool handle(WebServerType& server, HTTPMethod requestMethod, String requestUri) override { | ||
| bool handle(WebServerType& server, HTTPMethod requestMethod, const String& __requestUri) override { | ||
| String requestUri(__requestUri); | ||
| |
There was a problem hiding this comment.
This String copy can be handled differently in a further fixing commit.
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Passing String by value means a full copy-constructor/temporary
string creation which is slightly inefficient. Avoid that
by using const references.