Skip to content

Conversation

@d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Sep 30, 2018

(removed by mistake)

@earlephilhower
Copy link
Collaborator

This fixes my issue uploading SPIFFS.

Trying an upload with a 4M (no SPIFFS) setting, which should error, gives:

[SPIFFS] data : /home/earle/Arduino/BearSSL_CertStore1/data [SPIFFS] size : -20 [SPIFFS] page : 256 [SPIFFS] block : 8192 terminate called after throwing an instance of 'std::bad_alloc' what(): std::bad_alloc SPIFFS Create Failed! 

With the removed if spiffs_kb>0, though, it would give a slightly more informative error
SPIFFS Not Defined for LOLIN(WEMOS) D1 R2 & mini, 80 MHz, Flash, 4M (no SPIFFS), v2 Lower Memory, Disabled, None, Only Sketch, 921600

Really a matter of preference, since it's an error and both are pretty obvious when you look at them.

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixed my issue/

@devyte devyte merged commit 88d0a15 into esp8266:master Oct 1, 2018
@d-a-v d-a-v deleted the boardspiffs branch October 2, 2018 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants