feat(rule): add prefer-promise-static-methods rule #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
zloirock reviewed May 29, 2024
| function reportIfIsPromiseCall(callNode, constructorNode, parameterNames) { | ||
| if ( | ||
| callNode.callee.type === 'Identifier' && | ||
| callNode.arguments.length <= 1 |
There was a problem hiding this comment.
What about new Promise(resolve => resolve(itCanThrowAnError())) (the case of Promise.try)?
There was a problem hiding this comment.
Hmm I'm not sure what the best approach there would be. (Also I didn't realize new Promise is same tick, I must've misread the spec.) Perhaps just show a suggestion instead of an autofix?
There was a problem hiding this comment.
I think that cases that could throw an error should be ignored (however, it's too many possible cases - I think that it's OK to ignore only call and new). Also, can be added an option to check such cases, without autofixes.
voxpelli changed the title voxpelli changed the title voxpelli changed the title prefer-promise-static-methods rule Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Closes #448
Rule to recommend using Promise static resolve/reject methods over new Promise, which saves a microtick and is more readable. See issue for more details on the rule.