Skip to content

Conversation

pre-commit-ci bot added 2 commits July 19, 2021 22:05
updates: - [github.com/pre-commit/pre-commit-hooks: v2.4.0 → v4.0.1](pre-commit/pre-commit-hooks@v2.4.0...v4.0.1) - [github.com/kynan/nbstripout: master → 0.5.0](kynan/nbstripout@master...0.5.0) - [github.com/psf/black: stable → 21.7b0](psf/black@stable...21.7b0)
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ericmjl
Copy link
Owner

ericmjl commented Aug 1, 2021

Closing this PR. In my mind the CI system is becoming meaningless because we have multiple versions of the same notebook & source code living in a single branch. The CI checks for notebooks & source code become meaningful only if there's a single source of truth, because then we can target the checks against those notebooks & source code only.

@ericmjl ericmjl closed this Aug 1, 2021
@ericmjl ericmjl deleted the pre-commit-ci-update-config branch August 1, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants