Skip to content

Add new options to rel make #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
encounter merged 1 commit into from
Mar 31, 2025
Merged

Add new options to rel make #94

encounter merged 1 commit into from
Mar 31, 2025

Conversation

@dbalatoni13
Copy link
Contributor

@dbalatoni13 dbalatoni13 commented Mar 31, 2025

Partially handles issue #93 till now by adding the REL version option. When trying to build Mario Party 4 RELs without config, the section count also didn't match up with what it should be.

Which ones exactly would make sense to be configurable manually?
@encounter
Copy link
Owner

encounter commented Mar 31, 2025

I'm thinking all we need is --version on the CLI for now. The other options, like section count, are more of a matching hack than anything. I'm hoping they won't be necessary to set outside of a byte-matching environment.
@encounter
Copy link
Owner

encounter commented Mar 31, 2025

Thanks for the PR!
@encounter encounter merged commit 614d4f2 into encounter:main Mar 31, 2025
16 checks passed
@encounter encounter mentioned this pull request Mar 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@dbalatoni13 @encounter