Hotfix/unknown writer #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 3 commits September 15, 2021 11:28
…o already announced endpoints. The remote SEDP writer will not send us existing endpoints through acknacks, as samples have been acknowledged before. When using multicast, the other side will set readerEntityId to ENTITYID_UNKNOWN, thus we are not able to match messages to our local endpoints. Solution: * keep track of all unmatched remote endpoints * when adding new endpoints, the set of unmatched remote endpoints is used to establish matches to previously announced endpoints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue: when adding endpoints later on, we have no way to match them to already announced endpoints. The remote SEDP writer will not send us existing endpoints through acknacks, as samples have been acknowledged before. When using multicast, the other side will set readerEntityId to ENTITYID_UNKNOWN, thus we are not able to match messages to our local endpoints.
Solution:
* keep track of all unmatched remote endpoints
* when adding new endpoints, the set of unmatched remote endpoints is used to establish matches to previously announced endpoints