Skip to content

avoiding checking if sys_thread_t typed variables are nullptr #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2022
Merged

avoiding checking if sys_thread_t typed variables are nullptr #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion include/rtps/entities/StatefulWriter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ template <class NetworkDriver> class StatefulWriterT final : public Writer {
NetworkDriver *m_transport;

HistoryCacheWithDeletion<Config::HISTORY_SIZE_STATEFUL> m_history;
sys_thread_t m_heartbeatThread = nullptr;
sys_thread_t m_heartbeatThread;

Count_t m_hbCount{1};

bool m_running = true;
Expand Down
2 changes: 1 addition & 1 deletion include/rtps/entities/StatefulWriter.tpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ bool StatefulWriterT<NetworkDriver>::init(TopicData attributes,
// Thread already exists, do not create new one (reusing slot case)
m_is_initialized_ = true;

if (m_heartbeatThread == nullptr || !m_thread_running) {
if (!m_thread_running) {

m_running = true;
m_thread_running = false;
Expand Down