Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Conversation

@kiennq
Copy link
Member

@kiennq kiennq commented Jun 30, 2019

Correct the usage of encode-time, will make the download of python-language-server-ms success.
The currently used syntax is only available in Emacs 27

@yyoncho
Copy link
Member

yyoncho commented Jun 30, 2019

@seagle0128 can you take a look?

@seagle0128
Copy link
Collaborator

I am fine with the change. I noticed @Isolet reported #39.

@Isolet, can you please test it?

@smallzhan
Copy link
Contributor

@seagle0128 @yyoncho According to my test in both Emacs26 & 27, this PR solves #39.

@seagle0128
Copy link
Collaborator

Thank you, @smallzhan .
@yyoncho , Please merge.

@yyoncho yyoncho merged commit 596d058 into emacs-lsp:master Jun 30, 2019
@kiennq kiennq deleted the bug/parse-fail branch June 30, 2019 17:57
@failable
Copy link

failable commented Jul 1, 2019

Still can't get it work

Command "/Users/isol/.emacs.d/savefile/var/lsp-python-ms/Microsoft.Python.LanguageServer" is not present on the path. Command "pyls" is present on the path. Found the following clients for /Users/isol/Git/tags.py: (server-id pyls, priority -1) The following clients were selected based on priority: (server-id pyls, priority -1) 

But the executable is in fact there.

@failable
Copy link

failable commented Jul 1, 2019

The extracted server has no executable flag.

-rw-r--r-- 1 isol staff 163K Jun 21 12:02 Microsoft.Python.LanguageServer 

I wonder if it's only the issue of my OS.

@seagle0128
Copy link
Collaborator

seagle0128 commented Jul 1, 2019

@Isolet Did you set lsp-python-ms-dir or lsp-python-ms-executable?
"/Users/isol/.emacs.d/savefile/var/lsp-python-ms/Microsoft.Python.LanguageServer" is not the default path. lsp-python-ms-dir and lsp-python-ms-executable shoud be matched. If the path is invalid, the chmod may not be executed correctly. You can try to run chmod +x manually.

@failable
Copy link

failable commented Jul 1, 2019

I only set lsp-python-ms-dir. lsp-python-ms-dir and lsp-python-ms-executable do match. I have to chmod +x manually.

@seagle0128
Copy link
Collaborator

@Isolet I set lsp-python-dir to ~/.emacs.d/var/lsp-python-ms/ and did test with Emacs 27 on macOS. It does work well. Please update to the latest version and retry.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

5 participants