This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Make lsp-python-ms work with the new "lsp.el" #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits December 4, 2018 20:51
Change-Id: I78918c06aa6af1588c346db9024180ec03a06404
Change-Id: I23591c9c65685516b8825487356f860aa209d57f
| @astenman Thanks, this looks great! To confirm - this supersedes the previous PR you submitted and closed, right? |
seanfarley added a commit to seanfarley/lsp-python-ms that referenced this pull request Dec 20, 2018
This fixes a linting error and also fixes the wrong method being used for the callback: lsp-python-ms--language-server-started was being used instead of lsp-python-ms--language-server-started-callback. That was most likely due to a bad merge from emacs-lsp#3.
| This seems to have been manually merged in and can probably be closed now. |
| @seanfarley thanks for noticing, closing now |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Change-Id: I78918c06aa6af1588c346db9024180ec03a06404