This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Add no-op "telemetry/event" handler, and improvments to workspace-root #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
yyoncho reviewed Jan 23, 2019
lsp-python-ms.el Outdated
| :initialization-options 'lsp-python-ms--extra-init-params | ||
| :notification-handlers (lsp-ht ("python/languageServerStarted" 'lsp-python-ms--language-server-started-callback)))) | ||
| :notification-handlers (lsp-ht ("python/languageServerStarted" 'lsp-python-ms--language-server-started-callback) | ||
| ("telemetry/event" (lambda (&rest r)))))) |
There was a problem hiding this comment.
nit: there is standard function 'ignore
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I added a no-op handler for "telemetry/event" to suppress errors I was getting because of that event.
Also,
lsp-python-ms--workspace-rootwasn't working correctly for me in the "new" lsp-mode, and I changed it to delegate to the new mode'slsp-workspace-rootfunction if available.